Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSL Engine cleanup #305

Merged
merged 4 commits into from
Jul 8, 2019
Merged

SSL Engine cleanup #305

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9864da
Free SSL engine when SSL stage is closed
Jul 5, 2019
a0afac7
Handle failures during SSL stage cleanup
Jul 8, 2019
3233778
Catch only SSLException during cleanup
Jul 8, 2019
d7705c7
Log exceptions during cleanup
Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/src/main/scala/org/http4s/blaze/pipeline/stages/SSLStage.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,17 @@ final class SSLStage(engine: SSLEngine, maxWrite: Int = 1024 * 1024)

}

override protected def stageShutdown(): Unit =
try {
engine.closeInbound()
engine.closeOutbound()
} catch {
case e: SSLException =>
//Ignore cleanup errors. Example: With JDK SSLContextImpl, if the connection is closed before even handshake
//began(like port scanning), an SSLException might be thrown.
logger.debug(e)("Error while closing SSL Engine")
}

private[this] val maxNetSize = engine.getSession.getPacketBufferSize
private[this] val maxBuffer = math.max(maxNetSize, engine.getSession.getApplicationBufferSize)

Expand Down