Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing the conversion from servlet request to http4s request #173

Open
asvanberg opened this issue Jan 27, 2023 · 2 comments
Open

Customizing the conversion from servlet request to http4s request #173

asvanberg opened this issue Jan 27, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@asvanberg
Copy link

It would be good if there was a way to adapt or extend the current request conversion which is hidden down in Http4sServlet if you want to extract additional attributes or populate the remote user for example.

@rossabaker
Copy link
Member

This is a fair idea. Do you have a vision for how you'd like that API to appear?

@rossabaker rossabaker added the enhancement New feature or request label Feb 2, 2023
@asvanberg
Copy link
Author

If it was possible to pass a (HttpServletRequest, Request) => ParseResult[Request] or maybe allow effects and return F[ParseResult[Request]] to the builder/apply that would work well I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants