Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Uri.uri calls in the docs. #2603

Closed
rossabaker opened this issue May 29, 2019 · 3 comments
Closed

Remove Uri.uri calls in the docs. #2603

rossabaker opened this issue May 29, 2019 · 3 comments
Labels
docs Relates to our website or tutorials good first issue A tractable issue for those looking to make an initial contribution

Comments

@rossabaker
Copy link
Member

rossabaker commented May 29, 2019 •
edited by aeons
Loading

Uri.uri(...) is deprecated in favor of a StringContext macro. We should replace all those calls in the tuts with uri"...".

Reported in #2598. Preventing this in the build in #2602. Separated as a quick win for someone looking for a first issue.
@rossabaker rossabaker added docs Relates to our website or tutorials good first issue A tractable issue for those looking to make an initial contribution labels May 29, 2019
@mcintdan
Copy link
Contributor

May I please be assigned this issue? I am a new contributor and believe I could help fix the documentation. :-)

@rossabaker
Copy link
Member Author

@mcintdan 👍 thanks! Please let us know here or on gitter if you need any help.

mcintdan added a commit to mcintdan/http4s that referenced this issue May 29, 2019
@mcintdan
replaced deprecated Uri.uri(...) with uri(...)
f44d38a 
Per Issue http4s#2063 Remove Uri.uri calls in the docs.
http4s#2603
This was referenced May 29, 2019
Closed
Merged
@rossabaker rossabaker assigned mcintdan and unassigned mcintdan Jul 5, 2019
@rossabaker
Copy link
Member Author

Oops, this is already fixed. We just neglected to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Relates to our website or tutorials good first issue A tractable issue for those looking to make an initial contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rossabaker @mcintdan