Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember Upgrade onto fs2.io.tls #3055

Merged
merged 6 commits into from Jan 21, 2020
Merged

Conversation

ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jan 10, 2020

No description provided.

Copy link
Member

@rossabaker rossabaker left a comment

Hypothetical because it requires an unreleased version of fs2? I like the API cleanup a lot.

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Jan 12, 2020

Yes, its currently on the snapshot that is unreleased, however its a major improvement IMO.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jan 18, 2020

I jumped on this to see if it's ready while I'm preparing releases. All credit for the important work to Chris.

@rossabaker rossabaker added this to the 0.21.0-RC1 milestone Jan 18, 2020
@rossabaker rossabaker changed the title Hypothetical Ember Upgrade onto fs2.io.tls Ember Upgrade onto fs2.io.tls Jan 18, 2020
@rossabaker rossabaker marked this pull request as ready for review Jan 18, 2020
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jan 19, 2020

Still a compile error:

[error] /home/ross/src/http4s/ember-client/src/main/scala/org/http4s/ember/client/EmberClientBuilder.scala:86:95: type mismatch;
[error]  found   : F[Option[fs2.io.tls.TLSContext]]
[error]  required: F[Option[F[fs2.io.tls.TLSContext]]]
[error]           .fold(Sync[F].delay(TLSContext.system(blocker)).attempt.map(_.toOption))(_.some.pure[F])
[error]                                                                                               ^

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Jan 20, 2020

This was changed afterwards due to comments from this PR, now I think the toOption stuff is now unecessary.

Copy link
Member

@rossabaker rossabaker left a comment

Is TLSContext.system(blocker) something we expect to fail, and want to swallow if it does? Maybe this type could be simplified to F[TLSContext]?

Compiling in my head with an unfamiliar API, so ignore me if this is nonsense.

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Jan 21, 2020

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jan 21, 2020

Oh, right, to delay the construction for those pathological cases where the default throws. Ugh. Yeah, good call.

@rossabaker rossabaker merged commit 9a4c5be into http4s:master Jan 21, 2020
2 checks passed
rossabaker added a commit that referenced this issue Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants