Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jawn module for cats-effect 3 #3871

Merged
merged 3 commits into from
Nov 18, 2020
Merged

jawn module for cats-effect 3 #3871

merged 3 commits into from
Nov 18, 2020

Conversation

yanns
Copy link
Contributor

@yanns yanns commented Nov 15, 2020

Fixes #3839

@rossabaker
Copy link
Member

Thanks! This is the right start. I think this has a couple subtleties that some similar tickets didn't:

  1. It depends on jawn-fs2, which needs to be published for cats-effect-3 and fs2-3. @aeons did the upgrade, but we never released. I'll work on that and report back.

  2. This one has decoders, which can now take a Concurrent effect instead of Sync. This will be a big improvement for people using tracing or other kleislis as their base effect.

@rossabaker
Copy link
Member

I should be able to release typelevel/jawn-fs2 after typelevel/jawn-fs2#151. It's bad to change the publishing organization without changing the root package.

This will require a change to the dependency in Http4sPlugin, and probably an import change in this module.

@yanns
Copy link
Contributor Author

yanns commented Nov 16, 2020

1. It depends on jawn-fs2, which needs to be published for cats-effect-3 and fs2-3.  @aeons did the upgrade, but we never released.  I'll work on that and report back.

OK, I'll wait for the release.

2. This one has decoders, which can now take a `Concurrent` effect instead of `Sync`.  This will be a big improvement for people using tracing or other kleislis as their base effect.

13995c5

@rossabaker
Copy link
Member

I just released jawn-fs2-2.0.0-M2. It's now published under org.typelevel instead of org.http4s, and all Scala imports change from jawnfs2 to org.typelevel.jawn.fs2.

@yanns
Copy link
Contributor Author

yanns commented Nov 18, 2020

The builds are failing.
My quick check if that we would need #3868 on this branch.
@rossabaker what should we do?
Should I try to cherry-pick #3868 on the cats-effect-3 branch?
Or do we ignore the CI checks for now?
(sbt test is running locally)

@rossabaker
Copy link
Member

It looks right, it passes locally, we know why it failed on CI, and it's not yet a production branch. Let's take the easy way out and merge it. There's time to fix it if we guessed wrong.

Thanks!

@rossabaker rossabaker merged commit 81db7bf into http4s:cats-effect-3 Nov 18, 2020
@yanns yanns deleted the jawn_ce3 branch November 19, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants