Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response::Body#read doesn't work #114

Closed
jwinter opened this issue Mar 27, 2014 · 1 comment
Closed

Response::Body#read doesn't work #114

jwinter opened this issue Mar 27, 2014 · 1 comment
Milestone

Comments

@jwinter
Copy link
Contributor

jwinter commented Mar 27, 2014

https://github.com/tarcieri/http/blob/master/lib/http/response/body.rb#L17 calls the Client#read method, which doesn't exist. Would submit a pull request, but not sure if Body#read should be deleted or updated to used readpartial or something else.

@ixti ixti added this to the v0.6 milestone Mar 27, 2014
@ixti ixti closed this as completed in 54b747b Mar 27, 2014
@ixti
Copy link
Member

ixti commented Mar 27, 2014

I have removed it. It will be introduced back in releases following 0.6 (once #72 is finished).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants