Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

priorities: remove last vestiges of override #1065

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Conversation

LPardue
Copy link
Contributor

@LPardue LPardue commented Feb 18, 2020

We still had usage of the term override, so while thinking how to address that I took the opportunity to state explicitly that no guidance is provided for how an intermediary might merge.

@LPardue LPardue requested a review from kazuho February 18, 2020 15:48
@LPardue LPardue mentioned this pull request Feb 18, 2020
Copy link
Contributor

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!


Absence of a priority parameter in an HTTP response indicates the server's
disinterest in changing the client-provided value. This is different from the
logic being defined for the request header field, in which omission of a
priority parameter implies the use of their default values (see #parameters).

For example, when the client sends an HTTP request with
A non-normative example, when the client sends an HTTP request with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To a non-native speaker, "As a non-normative example" sounds more natural, though I am not sure if it's actually better.

Copy link
Contributor

@kazuho kazuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LPardue LPardue merged commit 5824fb8 into master Feb 27, 2020
@LPardue LPardue deleted the merging-language-tweaks branch February 27, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants