Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you planning a new release? #18

Closed
gep13 opened this issue Feb 14, 2016 · 13 comments
Closed

Are you planning a new release? #18

gep13 opened this issue Feb 14, 2016 · 13 comments

Comments

@gep13
Copy link

gep13 commented Feb 14, 2016

@huafu I was just wondering if you were planning on generating a new release soon?

There is at least one fix on the develop branch that we would like to see pushed as a new release, as it allows us to run this Hubot Gitter on Azure. Thanks in advance!

@huafu
Copy link
Owner

huafu commented Feb 14, 2016

I have to say the true, it is so long I did not work on this.... can't remember what implies a new release ;-)
So I'll now digg in that :-D

@gep13
Copy link
Author

gep13 commented Feb 15, 2016

@huafu that is great news! I wish I could help, but I haven't really dealt with npm packages before. Happy to test something out once you have something ready though. Thanks!

@huafu
Copy link
Owner

huafu commented Feb 15, 2016

Oh! Your message now actually reminds me how to do (well, more likely what
to do haha). I am on my phone now but I'll try to do this next time I'm on
my computer

On Mon, Feb 15, 2559 at 14:31 Gary Ewan Park notifications@github.com
wrote:

@huafu https://github.com/huafu that is great news! I wish I could
help, but I haven't really dealt with npm packages before. Happy to test
something out once you have something ready though. Thanks!


Reply to this email directly or view it on GitHub
#18 (comment).

@mose
Copy link
Collaborator

mose commented Sep 4, 2016

We really need a new release, the currently available npm package v0.1.3 is broken (and fixed only on 723a776). If you need any help in publishing, I can help.

@davidchambers
Copy link
Collaborator

I've opened #27 to make your life easier, @huafu. Here's the plan:

  1. Merge integrate xyz for effortless releases #27.
  2. Merge master into develop. develop should at all times be a superset of master.
  3. Pull from develop into master, so both point to the same commit (the merge commit for integrate xyz for effortless releases #27). This will be a fast forward.
  4. Run npm run release minor (while on master).
  5. Pull from master into develop. This will be a fast forward, and will ensure that develop remains a superset of master.
  6. Consider simplifying the branching strategy. ;)

The last step is optional, and a bit cheeky! In my experience having "stable" and "development" branches is more trouble than it's worth, but you may have good reasons for having separate branches for this repository.

Let me know if I can provide further assistance. If you like, @huafu, you could add me as a contributor and I could take care of all these steps (except the last one, which is obviously your call). I realize I'm a complete stranger, but I hope my GitHub profile indicates that I have good intentions. I'm just doing what I can to move this issue forward after one year. :)

@huafu
Copy link
Owner

huafu commented Nov 22, 2017

@davidchambers and @mose I am going to add you as a contributors, I am in need of some help here.
I actually prepared a release in release/0.2.0 with updated package versions (and the use of yarn), but I wanted to test it before publishing... can't remember how to test, and no time to investigate now... I did not even use CoffeeScript since 2+ years I think (but that is not actually the issue).

Closing this for now, I guess adding you guys will solve this issue.

@huafu huafu closed this as completed Nov 22, 2017
@mose
Copy link
Collaborator

mose commented Nov 22, 2017

Okay, I will try to give it a go asap and feedback about it.

@huafu
Copy link
Owner

huafu commented Nov 22, 2017

Thanks!

@davidchambers
Copy link
Collaborator

I'm preparing a new xyz release. I'll then update #27 at which point we can easily release a new version of this package.

In addition to adding us as contributors, @huafu, could you add us as package owners?

$ npm owner add davidchambers hubot-gitter2
$ npm owner add mose hubot-gitter2

@huafu
Copy link
Owner

huafu commented Nov 27, 2017

@davidchambers done, sorry again for my bad reactivity...

@davidchambers
Copy link
Collaborator

Thanks, @huafu!

@davidchambers
Copy link
Collaborator

Version 1.0.0 is now available. 🎉

@gep13
Copy link
Author

gep13 commented Mar 13, 2018

@davidchambers this is great news! Thank you for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants