-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate xyz for effortless releases #27
Conversation
Have you any interest in merging this pull request, @huafu? |
We should specify |
package.json
Outdated
@@ -21,8 +22,18 @@ | |||
"url": "https://github.com/huafu/hubot-gitter2/issues" | |||
}, | |||
"homepage": "https://github.com/huafu/hubot-gitter2", | |||
"files": [ | |||
"/doc/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included this when removing .npmignore to avoid changing the list of files included in the tarball. Actually, though, I suggest we exclude this HTML documentation from the tarball. Do you agree, @huafu?
Is the HTML documentation up to date? If so, how is it updated? If not, shall we remove it from the repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc is outdated I guess, anyway:
- yes, remove
doc
from the release since it should be viewable online only - if I remember well there was a script generating the doc from the comments and then publishing it to the
gh-pages
branch, I'll try to take a look at that and give you more info...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed "/doc/"
from "files"
. :)
See #18
This pull request adds xyz as a dev dependency to support the following commands:
$ npm run release major
$ npm run release minor
$ npm run release patch
We can run one of the above with the
--dry-mode
option to see what it would do:Note that in the command above I specified
--branch xyz
because xyz will abort if one is on a different branch. In the actual command we specify--branch master
as I assume we only ever want to publish frommaster
.These commands will work provided the following assumptions hold:
xyz
is run from the specified branch;If you have any questions, @huafu, don't hesitate to ask. I'd love to see a new release soon so I can stop referencing a GitHub commit in my package.json. :)