support updating backup_strategy in opengauss #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jason-Zhang9309 could you add the change into acc test? thanks |
Jason-Zhang9309
force-pushed
the
dev-gaussdb
branch
from
15fefb8
to
92d6df1
Compare
Sure. It has been added. |
ShiChangkuo
suggested changes
Jan 19, 2021
| @@ -92,7 +92,7 @@ The following arguments are supported: | |||
| * `datastore` - (Optional, List, ForceNew) Specifies the datastore information. Structure is documented below. | |||
| Changing this parameter will create a new resource. | |||
|
|
|||
| * `backup_strategy` - (Optional, List, ForceNew) Specifies the advanced backup policy. Structure is documented below. | |||
| * `backup_strategy` - (Optional, List) Specifies the advanced backup policy. Structure is documented below. | |||
| Changing this parameter will create a new resource. | |||
There was a problem hiding this comment.
This line should also be deprecated.
Comment on lines
692
to
697
| updateOpts.KeepDays = &keep_days | ||
| updateOpts.StartTime = rawMap["start_time"].(string) | ||
| // Fixed to "1,2,3,4,5,6,7" | ||
| updateOpts.Period = "1,2,3,4,5,6,7" | ||
| // Fixed to "30" | ||
| updateOpts.DifferentialPeriod = "30" |
There was a problem hiding this comment.
we can use a more graceful way, like:
updateOpts := backups.UpdateOpts {
....
}
Jason-Zhang9309
force-pushed
the
dev-gaussdb
branch
from
92d6df1
to
70bcde4
Compare
Jason-Zhang9309
force-pushed
the
dev-gaussdb
branch
from
70bcde4
to
18aee15
Compare
|
New Test result: make testacc TEST='./huaweicloud' TESTARGS='-run TestAccOpenGaussInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccOpenGaussInstance_basic -timeout 360m -parallel 4
=== RUN TestAccOpenGaussInstance_basic
=== PAUSE TestAccOpenGaussInstance_basic
=== CONT TestAccOpenGaussInstance_basic
--- PASS: TestAccOpenGaussInstance_basic (1234.67s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 1234.714s |
ShiChangkuo
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support updating backup_strategy in opengauss
Test result: