PagedIterable dosn't use authentication #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm starting to think that we should send in the authentication header on all requests if one is given. I see no harm in doing that, and there seem to be many APIs that change what they return depending on if we are logged in or not. |
|
I am attempting to implement the pull request plugin and am having the issue that is reported above. Do you know when this might be fixed and available? |
|
A +1 from me. |
kohsuke
added a commit
that referenced
this pull request
Sep 13, 2012
…_authentication PagedIterable dosn't use authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving eg. pull requests or comments, authentication isn't used. For public repositories it's ok, but for private it ends up with
java.io.FileNotFoundException