Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to trigger builds with private repo #4

Closed
JenRed12 opened this issue Sep 6, 2012 · 9 comments
Closed

Unable to trigger builds with private repo #4

JenRed12 opened this issue Sep 6, 2012 · 9 comments

Comments

@JenRed12
Copy link

JenRed12 commented Sep 6, 2012

This is an awesome plug in! However, it seems that this does not work with private repositories. Does this seem correct to you and if so is there a way to get around it?

Thank you for your help!

@janinko
Copy link
Owner

janinko commented Sep 7, 2012

I've investigated this issue and found out that githup-api-plugin isn't using authentication when retrieving informations that are paged (such as pull requests and comments). I'll file a bug to the github-api-plugin.

@JenRed12
Copy link
Author

JenRed12 commented Sep 7, 2012

Thanks so much. Whenever you file the bug can you send me the information so I can track it? I really need the pull request\comment part to work ASAP!

@JenRed12
Copy link
Author

JenRed12 commented Sep 7, 2012

Actually, I just found the issue you submitted.

@JenRed12 JenRed12 closed this as completed Sep 7, 2012
@JenRed12 JenRed12 reopened this Sep 10, 2012
@jamescmartinez
Copy link

+1 to watch.

@janinko
Copy link
Owner

janinko commented Sep 12, 2012

github-api plugin issue is here: hub4j/github-api#19

@jamescmartinez
Copy link

I saw and followed.

@janinko
Copy link
Owner

janinko commented Sep 14, 2012

hub4j/github-api#19 is resolved in github-api-plugin 1.33

@janinko janinko closed this as completed Sep 14, 2012
@JenRed12
Copy link
Author

This still does not seem to be working correctly. My builds are now being triggered when I create a pull request to the private repo. However, it does not trigger a build if I comment in the pull request and it does not leave a comment in github after the build is complete. This is seems to be happening in public repos as well.

Let me know if this is still an issue with the guthub-api plugin and I will file it with him instead.

Thanks!

@janinko
Copy link
Owner

janinko commented Sep 14, 2012

Version 1.2 is using github's commit status (https://github.com/blog/1227-commit-status-api) so it should make comment only when asking for approval.
If the build really isn't started, can you please open new issue and if it's possible look into Jenkins console output / log for info (errors, ghprb output..)

janinko added a commit that referenced this issue Oct 20, 2012
valdisrigdon pushed a commit that referenced this issue Jan 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants