Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite nova #536

Closed
basepi opened this issue Jan 28, 2019 · 5 comments
Closed

Rewrite nova #536

basepi opened this issue Jan 28, 2019 · 5 comments

Comments

@basepi
Copy link
Collaborator

basepi commented Jan 28, 2019

Offload all of the processing code to the core audit module for DRY and consistency reasons. This will also allow us to drastically reduce the complexity of the profiles themselves.

@basepi
Copy link
Collaborator Author

basepi commented Jan 28, 2019

@alias454
Copy link
Contributor

Not sure if you are up for requests at this point but having a utility to convert existing audit files to the new format would be nice(whatever that may be).

@basepi
Copy link
Collaborator Author

basepi commented Jan 28, 2019

Yep, I will definitely handle the conversion. I'll probably have to write a slightly different routine for each audit module, but that will be way easier than rewriting the profiles from scratch.

@alias454
Copy link
Contributor

alias454 commented Jan 28, 2019

Cool. I wrote up something that will convert the yaml to csv then another script to read in the csv. The second stage uses pandas to read the csv and update a sqlite db. I'll attach the first stage py script if it might be helpful in anyway. Feel free to use it or not. The one thing I didn't do was split up the list of checks. I decided to just store that as a json blob.

Also, don't laugh since I'm not a programmer ;)
nova_audit_csv_prep.txt

@basepi
Copy link
Collaborator Author

basepi commented Jan 28, 2019

Thanks for the link! I'll keep it in mind. And I promise no judgment. :)

@jettero jettero closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants