Implements App Enabled Emails #211

discorick · 2016-02-23T17:59:37Z

Merges into discorick/canceled_and_expired_analytics
References https://github.com/huboard/corp/issues/48

The Scope of this this PR changed quite a bit during its life-time. From where we stand today this accomplishes the following:

Sets up Action::Mailer in the Saas Engine with some very basic layouts
Configures mailer previews and injects an interceptor to allow attachment previews (for things like images)
Adds a new user document in couchdb for every OAuth'd user for future opportunities to communicate with them
Adds mailcatcher and a puppet provisioner for it

discorick · 2016-02-23T18:02:34Z

@rauhryan @dahlbyk , Wanted to have some discussion around how we want to structure our couchdb docs - going to need to start saving docs for individual users to coordinate sending out helpful emails.

rauhryan · 2016-02-23T19:01:54Z

vendor/engines/saas/app/jobs/base_login_job.rb

+
+  def self.action(action)
+    @action = action
+  end


I remember having trouble subclassing class attributes

Why aren't you using the class_attr stuff here?

Not 100% following you. This is the same pattern we have been using with the Analytics Jobs, and the Issue Jobs for Child Class instance vars.

We use this pattern in the healthchecks

https://github.com/huboard/huboard-web/blob/master/lib/health_checking/health_checks/health_check.rb#L5-L40

I remember there was a reason for it

…ny other things) email tracking

…production

… sendgrid adapter

…te emails

…ilers

…dds configuration for production mailer

…ing for child emails, adds a commented InlinePreviewInterceptor

…ork)

…moves unecessary spec_helper

dahlbyk · 2016-03-14T21:44:14Z

config/environments/development.rb

@@ -1,4 +1,12 @@
 Rails.application.configure do
+  #Mailer Previews
+  config.action_mailer.preview_path = Saas::Engine.root.join('test/mailers')


Help me understand what this is doing.

This line points the Action::Mailer previewer to look for mailer previews in the Saas::Engine. Otherwise when we attempt to use previews Rails is not able to find them.

dahlbyk · 2016-03-15T06:16:16Z

vendor/engines/saas/Gemfile.lock

    nokogiri (1.6.6.2)
      mini_portile (~> 0.6.0)
-    rack (1.6.0)
+    rack (1.6.4)
    rack-test (0.6.3)
      rack (>= 1.0)
    rails (4.2.0)


Alarm bells are ringing, thus #237.

Gotcha, thanks for opening that!

dahlbyk · 2016-03-15T15:29:18Z

Pulled master in due to BaseLoginJob overlap in #232 - I told Git to use what's in master, but you might want to double-check: f2795e2#diff-409415fd755afb7ec1e211a3c1b9b519

discorick · 2016-03-15T15:46:52Z

@dahlbyk f2795e2#diff-409415fd755afb7ec1e211a3c1b9b519 did go a little bit sideways. I am not sure the how go about fixing it.

dahlbyk · 2016-03-15T16:20:10Z

f2795e2#diff-409415fd755afb7ec1e211a3c1b9b519 did go a little bit sideways. I am not sure the how go about fixing it.

How does 9746411#diff-409415fd755afb7ec1e211a3c1b9b519 look?

dahlbyk · 2016-03-16T03:57:40Z

dahlbyk closed this 3 minutes ago

Oops. GitHub used to prevent deleting branches targeted by open PRs. 👿

discorick · 2016-03-16T15:29:01Z

Should I just reopen this against master at this point ?

dahlbyk · 2016-03-16T17:37:05Z

Should I just reopen this against master at this point ?

Yup.

rauhryan reviewed Feb 23, 2016
View reviewed changes

dahlbyk mentioned this pull request Mar 3, 2016

Bumps rails from 4.2.0 -> 4.2.4 #217

Merged

discorick and others added 21 commits March 8, 2016 11:16

Removes dupe logic on login jobs in prep for email jobs

e17a46d

Starts building the mailer and the sendgrid adapter

cc6d304

Smartens up the rspec spec_helper

bdfbcbc

Finishes V1 of the SendGrid mail adapter

c792ce2

Adds mailer initializer

70111c7

Creates a couchdb doc for each logged-in user, allowing for (among ma…

134a6ce

…ny other things) email tracking

Moves the design/users view to a debug folder to avoid deployment to …

eefa6aa

…production

Finishes end-to-end application enabled emails, adds templates to the…

78e4ea5

… sendgrid adapter

Removes unecessary view, adds a pure "get" to the couch lib

4154acb

Removes 'require' for not existent file

8d6ed6c

Tweaks the CreateUserMail Job body

564b76d

Fixes bad logic, adds a check to prevent users from receiving duplica…

32ac2c6

…te emails

Removes the current Mailer in preparation for replacing with ActionMa…

e7f603a

…ilers

Spikes out initial mailer, gets previews working

4fd3c0b

Adds ActionMailer configuration

79c9659

Sets up mailcatcher for development, adds it to puppet provisioner, a…

b68856a

…dds configuration for production mailer

adds to existing welcome email html

e5202ed

Tweaks env vars

b2f6366

fixes action_mailer typo in production env

f7c4780

Uses the correct username key

8fb8dc3

Adds a Saas::ApplicationMailer class to provide basic layout and styl…

1e268db

…ing for child emails, adds a commented InlinePreviewInterceptor

discorick force-pushed the discorick+petedo/app_enabled_emails branch from 0ebbcd9 to 5ca810a Compare March 8, 2016 18:21

Adds a preview interceptor for mailer previews (makes inline images w…

ec376cf

…ork)

discorick force-pushed the discorick+petedo/app_enabled_emails branch from 5ca810a to ec376cf Compare March 8, 2016 18:24

dahlbyk added the 3 - In Review label Mar 9, 2016

discorick added 2 commits March 14, 2016 10:24

Removes sendgride gem, removes welcome_email from create_user_job, re…

abb4b68

…moves unecessary spec_helper

Restores newline that shouldnt be part of this PR

bc36ef1

dahlbyk reviewed Mar 14, 2016
View reviewed changes

dahlbyk mentioned this pull request Mar 15, 2016

Bump SaaS Rails to 4.2.4 #237

Merged

dahlbyk reviewed Mar 15, 2016
View reviewed changes

dahlbyk force-pushed the discorick+petedo/app_enabled_emails branch from 8385b9b to f2795e2 Compare March 15, 2016 15:24

dahlbyk force-pushed the discorick+petedo/app_enabled_emails branch from f2795e2 to f79f194 Compare March 15, 2016 16:17

Merge branch 'master' into discorick+petedo/app_enabled_emails

9746411

dahlbyk force-pushed the discorick+petedo/app_enabled_emails branch from f79f194 to 9746411 Compare March 15, 2016 16:18

discorick self-assigned this Mar 15, 2016

dahlbyk deployed to huboard-rails-pr-211 March 16, 2016 00:20 Active

dahlbyk closed this Mar 16, 2016

discorick mentioned this pull request Mar 16, 2016

Prepares for application emails #242

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implements App Enabled Emails #211

Implements App Enabled Emails #211

discorick commented Feb 23, 2016

discorick commented Feb 23, 2016

rauhryan Feb 23, 2016

discorick Feb 23, 2016

rauhryan Feb 25, 2016

dahlbyk Mar 14, 2016

discorick Mar 15, 2016

dahlbyk Mar 15, 2016

discorick Mar 15, 2016

dahlbyk commented Mar 15, 2016

discorick commented Mar 15, 2016

dahlbyk commented Mar 15, 2016

dahlbyk commented Mar 16, 2016

discorick commented Mar 16, 2016

dahlbyk commented Mar 16, 2016

Implements App Enabled Emails #211

Implements App Enabled Emails #211

Conversation

discorick commented Feb 23, 2016

discorick commented Feb 23, 2016

rauhryan Feb 23, 2016

Choose a reason for hiding this comment

discorick Feb 23, 2016

Choose a reason for hiding this comment

rauhryan Feb 25, 2016

Choose a reason for hiding this comment

dahlbyk Mar 14, 2016

Choose a reason for hiding this comment

discorick Mar 15, 2016

Choose a reason for hiding this comment

dahlbyk Mar 15, 2016

Choose a reason for hiding this comment

discorick Mar 15, 2016

Choose a reason for hiding this comment

dahlbyk commented Mar 15, 2016

discorick commented Mar 15, 2016

dahlbyk commented Mar 15, 2016

dahlbyk commented Mar 16, 2016

discorick commented Mar 16, 2016

dahlbyk commented Mar 16, 2016