Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to hubot-scripts.json fixes #75 #91

Merged
merged 2 commits into from
Jun 26, 2017

Conversation

lornajane
Copy link
Contributor

@lornajane lornajane commented Jun 18, 2017

This file is no longer used; the generator creates an empty one and the
bot then produces a warning to delete the empty file. This patch just
removes the file from the generator so fresh installs never need to care
about this.

closes #75

This file is no longer used; the generator creates an empty one and the
bot then produces a warning to delete the empty file.  This patch just
removes the file from the generator so fresh installs never need to care
about this.
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and it works. Changes look good to me, too

@gr2m
Copy link
Contributor

gr2m commented Jun 26, 2017

@technicalpickles any objection against merging this in?

Copy link
Member

@technicalpickles technicalpickles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gr2m Nope :shipit:

@gr2m gr2m merged commit 88be1e6 into hubotio:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hubot-scripts.json is deprecated
3 participants