Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubot-scripts.json is deprecated #75

Closed
iancward opened this issue Dec 2, 2016 · 4 comments · Fixed by #91
Closed

hubot-scripts.json is deprecated #75

iancward opened this issue Dec 2, 2016 · 4 comments · Fixed by #91
Labels
bug

Comments

@iancward
Copy link

iancward commented Dec 2, 2016

The generator script creates a hubot-scripts.json file, which is deprecated. It should be removed from the generator

https://github.com/github/generator-hubot/blob/97746f1fe73df1aa00859c9a8c9ba5fd4fedae9e/generators/app/index.js#L254

https://github.com/github/hubot/blob/498d65611388d2881e6ae24f74bd68a832a24211/bin/hubot#L110-L112
@stale stale bot added the stale label Jun 1, 2017
@stale
Copy link

stale bot commented Jun 1, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@iancward
Copy link
Author

iancward commented Jun 1, 2017

Hi,
This is still an issue.

@stale stale bot removed the stale label Jun 1, 2017
lornajane added a commit to lornajane/generator-hubot that referenced this issue Jun 18, 2017
@lornajane
Remove references to hubot-scripts.json fixes hubotio#75
235cc94 
This file is no longer used; the generator creates an empty one and the
bot then produces a warning to delete the empty file.  This patch just
removes the file from the generator so fresh installs never need to care
about this.
@PadmaChannal
Copy link

I am facing the same problem. What might be the solution for this?
image

@lornajane lornajane mentioned this issue Jun 26, 2017
Merged
@gr2m
Copy link
Contributor

gr2m commented Jun 26, 2017

we already have a pull request that will resolve this issue at #91. We hope to merge and release it soon :)

@gr2m gr2m closed this as completed in #91 Jun 26, 2017
gr2m added a commit that referenced this issue Jun 26, 2017
@gr2m
Merge pull request #91 from lornajane/remove-hubot-scripts
88be1e6 
Remove references to hubot-scripts.json fixes #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove references to hubot-scripts.json fixes #75 lornajane/generator-hubot
4 participants
@technicalpickles @gr2m @iancward @PadmaChannal