-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User attributes saved to the hubot brain are lost on restart #738
Comments
What do you have in If you do have one (like redis-brain.coffee), do you see any output during startup that the brain couldn't be connected? |
We're using the redis-brain.coffee script. Seems to be connecting just fine. Here's the behavior I'm seeing... I set my githubLogin via github-credentials.coffee: {
"id": "devon",
"jid": "room@conference.team.xmpp.slack.com/devon",
"privateChatJID": "devon@team.xmpp.slack.com",
"name": "devon",
"type": "chat",
"githubLogin": "dblandin"
} I restart hubot. Here are some select start up logs:
Here's my user in the redis hubot brain after restart: {
"id": "devon",
"room": "room@conference.team.xmpp.slack.com",
"jid": "room@conference.team.xmpp.slack.com/devon",
"privateChatJID": "devon@team.xmpp.slack.com",
"name": "devon"
} |
Seems like this may be related to slackapi/hubot-slack#63 |
I'm now using the new hubot-slack adapter and am no longer experiencing this issue. Seems to be up to the adapter to handle room switching properly. |
Some context:
I'm using scripts such as github-credentials.coffee and harvest.coffee which save attributes to a user within the hubot brain.
Everything persists correctly while hubot is running but as soon as I need to restart hubot (for an upgrade or otherwise), all of the user data is lost.
I'm thinking that this might be related to how hubot loads user data on load, and instead of merging, the loaded user data is overriding the existing user data. Does that sound plausible?
I'm using the hubot-xmpp adapter.
The text was updated successfully, but these errors were encountered: