Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently Updated Deals incorrect param 'limit' should be 'count' I believe #34

Closed
TimWhitbeck opened this issue Oct 4, 2018 · 4 comments
Labels
1.0.0 bug Something isn't working

Comments

@TimWhitbeck
Copy link

When getting recently updated deals the Hubspot API is looking for a parameter named 'count' from looking at the source it's attempting to set a parameter 'limit' - outcome is that no matter what 'limit' is passed in it's returning the default of 20 deals.

@Psypher9
Copy link
Member

Thank you for pointing this out! We are in the process of making some major updates, so we will be sure to clean that up.

@Psypher9 Psypher9 added the bug Something isn't working label Oct 23, 2018
@TimWhitbeck
Copy link
Author

Just a note, this seems to be causing a larger issue at least from the hubspot sandbox environment. I believe the change happened on Hubspots end. Again I haven't had the opportunity to test this against our production hubspot so in dev if i make two calls to getrecentlyupdateddeals. I get the following message on the second call "Cannot fetch more than 10000 total records for this endpoint". Seems very odd since our sandbox doesn't even have 10K records in it but I believe if we can make this use the count parameter we will be able to get past it. Any ideas on a release date?

@Psypher9
Copy link
Member

Wow. Thanks for the update on this. I don't have a set time for when I can work on a fix for this yet. We can definitely entertain a PR on this though.

@Psypher9
Copy link
Member

Psypher9 commented Jun 9, 2019

Thanks again for pointing this out @TimWhitbeck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants