Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorry to be that guy, but IE8 is giving me shit. #20

Closed
joepagan opened this issue Mar 17, 2014 · 3 comments
Closed

Sorry to be that guy, but IE8 is giving me shit. #20

joepagan opened this issue Mar 17, 2014 · 3 comments

Comments

@joepagan
Copy link

Getting the same issue on your demo page as well as my own website.
IE9 is ok IE8 is not.

Doesn't seem to like the defining a new drop:
newDrop = new Drop({

https://www.dropbox.com/s/o94ey01vywlso6z/Screenshot%202014-03-17%2010.47.38.png

newDrop = new Drop({

Specifically it's moaning about this in drop.js (I've added some text pointing out the line in the function below)

(function() {
var event, lastCall, lastDuration, pendingTimeout, tick, _i, _len, _ref1, _results;
lastCall = null;
lastDuration = null;
pendingTimeout = null;
tick = function() {
  if ((lastDuration != null) && lastDuration > 16) {
    lastDuration = Math.min(lastDuration - 16, 250);
    pendingTimeout = setTimeout(tick, 250);
    return;
  }
  if ((lastCall != null) && (now() - lastCall) < 10) {
    return;
  }
  if (pendingTimeout != null) {
    clearTimeout(pendingTimeout);
    pendingTimeout = null;
  }
  lastCall = now();
  position();
  return lastDuration = now() - lastCall;
};
_ref1 = ['resize', 'scroll', 'touchmove'];
_results = [];
for (_i = 0, _len = _ref1.length; _i < _len; _i++) {
  event = _ref1[_i];
  _results.push(window.addEventListener(event, tick)); // IT'S MOANING ABOUT THIS LINE 
}
return _results;
})();
@zackbloom
Copy link
Contributor

Sorry for the inconvenience this has caused you, but drop doesn't support IE8. For a more detailed explanation of why, see the tether docs.

@joepagan
Copy link
Author

Hey Zack,

Thanks for letting me know, completely get why people don't support it anymore, and I'd love to not. I hate all the IEs with passions just like any other Dev.

Unfortunately working at an agency it's more dependant on the % of user's of our client's websites.

I certainly do hope that IE8 users burn in a horrible fire, but, I would prefer it if the plugin would have just not worked, rather than throwing a js error which could potentially fuck up other js code on the site.

@joepagan
Copy link
Author

For those who want to not getting an error on IE8 you can try wrap your "new Drop" call in an if like so & only call drop.js on the page in question to limit errors.

if(typeof(Drop) != "undefined"){}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants