-
Notifications
You must be signed in to change notification settings - Fork 848
After updating to v0.6.0 issues #48
Comments
The default check is changed to xhr, and the default image/xhr don't exist. So you have to set the options.
or
|
I might be doing something wrong but I think the new version is somewhat broken. on version 0.4.7 all I needed to do is add JS and CSS from the page and it works. The only browser it didn't work was Firefox so I added this: On new version 0.6.0 the code is a must and only works if i use xhr with errors. Image detection does not work anymore. If I put a wrong URL in the "image: { url:" then it will display the notification even I am online but as long as I use older version CSS (new one does not even show up). The old CSS does not show the timer Reconnecting in anymore (instead shows ...). If the image is correct when it will not show any 404 errors but when I disconnect Internet nothing happens. I'll try few more things but I am running out of ideas. It simply doesn't work anymore :/ |
I added this:
And placed the tiny-image.gif on my own domain. When just using a static filename, it only triggers the first check and then loads from cache (I suspect) |
Well your solution does work to me. Kinda strange way to do it :) Maybe there will be a better solution in the future. You might be able to add this functionality in the offline.min.js and only set option to chose what u want xhr or image? Thanks for your help. At least temporarily it works now |
Yeah it changed with this commit: a8b9773 |
@barryvdh your fix worked for me, thank you! It would certainly be helpful for the docs to be updated to specify the new config requirements. Thanks all! |
This solution does not work for 3G connection, only with Wifi. Do you have any workaround? |
The fix mentioned by @barryvdh also worked for me. We were using the old library are starting getting a ton of 403 errors out the blue. |
v0.7.0 now uses your favicon as the test image, assuming you have a /favicon.ico, you should see no problems. |
HEAD http://[my domain]/offline-test-request/498128607
404 Not Found
36ms
I am constantly getting bombarded with those errors in firebug. Is this intended? IMHO it should not show errors when checking.
The text was updated successfully, but these errors were encountered: