Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It doesn't work in Firefox #18

Closed
smartcorestudio opened this issue Jan 21, 2015 · 3 comments
Closed

It doesn't work in Firefox #18

smartcorestudio opened this issue Jan 21, 2015 · 3 comments

Comments

@smartcorestudio
Copy link

You can just check your demo in FF36.
@smartcorestudio
Copy link
Author

It works if we comment the line
"touchDevice = 'ontouchstart' in document.documentElement"

@adamschwartz
Copy link
Contributor

Thanks for reporting this @smartcorestudio. Sorry for the delay. I just tested in FF39 for Mac OS X and it worked. Do you think it’s possible #23 was the issue? (Were you on a 2-in-1 or tablet running Firefox?) Thanks in advance.

adamschwartz added a commit that referenced this issue Sep 16, 2015
@adamschwartz
refactor
cab1613 
- better handling of touch events (#23, #18)
- allow type to be overridden with `data-` and allow custom types to be set up via `sortable.setupTypes`, uses cleaner compare fns (#21, #17, #16)
- add `CustomEvent` when sorting finishes (#25)
- amd/commonjs (#10)
- stable sort (#14)
- performance improvements when reversing

thx for the help @zackbloom
@adamschwartz
Copy link
Contributor

Assuming this was #23, that was fixed with cab1613. Please let us know though if your issue isn’t fixed by cab1613 and we’ll reopen. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamschwartz @smartcorestudio