-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vex.combined and AMD #38
Comments
Can you be more specific about what you mean when you you can't make it work with requireJS? Including vex.js and vex.dialog.js (in that order) should be equivalent to including vex.combined.js. |
It does work by including vex and vex.dialog separately. But I can't not make it work using vex.combined. when using vex.combined only the main vex object get exposed but not vex.dialog. is this a known bug ? |
Still hoping to get that figured out if i have to go to production with this.. Are you aware of this issue or I am doing something wrong. |
Sorry, my previous statement was incorrect. The vex.combined.min.js file has two If your goal is to use |
Ok thanks, would love to seem the AMD version only expose one object tho |
@m4nuC can you elaborate? |
I meant just having one object exposed in the vex.combined.min to make it usable when using AMD. Obviously not a big deal but that would to me look a bit nicer in my list of dependencies. |
Unfortunately (and @zackbloom or @timmfin please correct me if i'm wrong), I believe the only way to accomplish this would be to actually combine the source code of Generalized, this is an interesting AMD question, and one I'd certainly like an answer to: Can one structure her code such that modules A and B (in which B depends on A) can be required as a single module C or individually as modules A and B respectively? If you figure it out, please report back and let us know. 😉 |
Well can't module C require B (which require A) and then just expose a C module that can itself expose B module through a member on itself ? I would try it out but I am not exactly a coffee scripter :( |
That sounds reasonable. I can give it shot next week. Thanks! |
I can't make vex.combined work with requireJS.
It seems to only work when using the separate vex.js and vex.diaolog.js ( like in the AMD exemple).
I was hoping to just load the vex.combined and be able to use vex.dialog. Possible?
The text was updated successfully, but these errors were encountered: