Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding name and version fields to generated package.json #928

Closed
chopfitzroy opened this issue Sep 8, 2020 · 1 comment
Closed

Adding name and version fields to generated package.json #928

chopfitzroy opened this issue Sep 8, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@chopfitzroy
Copy link

Describe the bug
A clear and concise description of what the bug is.

Currently the cli does not add name or version to the package.json this can cause issues when working with tools like lerna.

To Reproduce
Steps to reproduce the behaviour:

  1. Generate new project
  2. Open package.json
  3. name and version are not present

What is the expected behaviour?
A clear and concise description of what you expected to happen.

Fields would be added, name based on name given when using cli and version could default to something like 0.0.0 or 1.0.0.

Screenshots
If applicable, add screenshots to help explain your problem.

About the environment
Which versions of botonic packages, and which browser/OS or environment (development/production) are affected by this issue? Did this work in previous versions of botonic packages?

Using latest cli version.

Additional context
Add any other context about the problem here.

@vanbasten17
Copy link
Contributor

We have added both name and version to every template in the new released package. Thanks for reporting! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants