Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/improve telemetry #1305

Merged
merged 7 commits into from Feb 10, 2021
Merged

Chore/improve telemetry #1305

merged 7 commits into from Feb 10, 2021

Conversation

vanbasten17
Copy link
Contributor

@vanbasten17 vanbasten17 commented Feb 9, 2021

Description

Fixes to be included in a 0.18.1 release.

  • Track botonic new at the very beginning of its execution.
  • Update @oclif dependencies in package.json
  • Track if is interactive console, node version, path to botonic binary, $PATH and current working directory.
  is_tty: true,
  node_version: 'v12.20.1',
  binary_path: '/usr/local/bin/botonic',

Once approved: including these changes also in https://github.com/hubtype/botonic-examples

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #1305 (2ea4c6c) into master (37f992c) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
- Coverage   61.01%   60.94%   -0.07%     
==========================================
  Files         247      247              
  Lines        7069     7077       +8     
  Branches     1193     1194       +1     
==========================================
  Hits         4313     4313              
- Misses       2430     2438       +8     
  Partials      326      326              
Flag Coverage Δ
botonic-cli 0.36% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/botonic-cli/src/commands/new.ts 0.00% <0.00%> (ø)
packages/botonic-cli/src/utils.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d4af4...2ea4c6c. Read the comment docs.

packages/botonic-cli/src/utils.ts Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@asastre asastre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/botonic-cli/src/utils.ts Outdated Show resolved Hide resolved
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@vanbasten17 vanbasten17 merged commit d4c95de into master Feb 10, 2021
@vanbasten17 vanbasten17 deleted the chore/improve-telemetry branch February 10, 2021 11:27
@github-actions
Copy link

Unit Test Results

1 files  1 suites   2s ⏱️
1 tests 1 ✔️ 0 💤 0 ❌

Results for commit d4c95de.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants