Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contentful): improve error reporting #1470

Merged
merged 2 commits into from Apr 28, 2021

Conversation

dpinol
Copy link
Contributor

@dpinol dpinol commented Apr 20, 2021

Description

Improvements in CmsException:

  • Message now includes resourceId so that CMS.contents & CMS.topContents also report it.
  • Removed "Due to: " to separate exception msg from reason

Context

Oftentimes contentful contents get corrupted (broken links to deleted or archived contents).
It's very important that the error reporting that we get when loading/validating broken contents is as detailed and clean as possible

To document / Usage example

Testing

The pull request...

  • has unit tests

CmsException message to include resourceId so that contents & topContents
also report it.
Removed "Due to: " to separate exception msg from reason
Base automatically changed from contentful/reduce-qa-contents to master April 21, 2021 08:24
@dpinol dpinol marked this pull request as ready for review April 21, 2021 08:29
Copy link
Contributor

@elozano98 elozano98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@dpinol dpinol merged commit bea2b4e into master Apr 28, 2021
@dpinol dpinol deleted the contentful/exception-improvements branch April 28, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants