feat(react): refactor to allow hostId to be changed at runtime #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asastre
requested review from
ericmarcos,
marcpdw,
vanbasten17 and
AinaVendrell
vanbasten17
approved these changes
Oct 26, 2021
marcpdw
approved these changes
Oct 26, 2021
Khaeshah
approved these changes
Oct 26, 2021
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor to allow the
hostIdto be specified at runtime within the integration code of the webchat (as an attribute of the webchat configuration) to get rid of a warning in the browser's console.Context
If the id of the HTML Element where the webchat is rendered was different than
root, this warning was showing up:And setting the
hostIdattribute at runtime as a webchat configuration when initializing the webchat wasn't working.Approach taken / Explain the design
To document / Usage example
Testing
The pull request has unit tests.