Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:emoji clarification Icon can not work on widget in shadow dom #2240

Merged
merged 3 commits into from Feb 9, 2023

Conversation

TD-fupengfei
Copy link
Contributor

@TD-fupengfei TD-fupengfei commented Jun 1, 2022

Description

Fix problem1:When using shadowDOM mode. The first time you click the emoji button.The emoji selection box pops up.
Fix problem2: Emoji clarification Icon can work on widget in shadow dom

Context

shadowDOM mode
fix before:

2022-06-01.1.59.18.mov

fix after:

2022-06-01.2.04.41.mov

Approach taken / Explain the design

To document / Usage example

Testing

The pull request...

  • has unit tests
  • has integration tests
  • doesn't need tests because... [provide a description]

Copy link
Contributor

@ericmarcos ericmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for your contribution! =D

@TD-fupengfei
Copy link
Contributor Author

Nice! Thanks for your contribution! =D

Hello, may I ask when this can be updated? Some tasks we have need to use

@ericmarcos ericmarcos merged commit 469034f into hubtype:master Feb 9, 2023
ericmarcos pushed a commit that referenced this pull request Feb 9, 2023
)

* fix:emoji clarification Icon can not work on widget in shadow dom

* fix:emoji clarification Icon can not work on widget in shadow dom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants