feat: allow to deploy bot with email and password throw cli #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpinol
approved these changes
Jan 22, 2020
vanbasten17
approved these changes
Jan 22, 2020
Comment on lines
65
to
66
| let email = flags.email ? flags.email : undefined | ||
| let password = flags.password ? flags.password : undefined |
There was a problem hiding this comment.
same here as Dani suggest above. I'm wondering if we could update @botonic/cli to latest typescript versions to use the newest features/syntax as for example https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#nullish-coalescing
There was a problem hiding this comment.
@vanbasten17 good point, actually cli already uses 3.7!
actually I'm not sure why @guinii converts the empty values to undefined
There was a problem hiding this comment.
Both of you are right! I change the declaration! Thanks guys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.