-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition manuscript file to .qmd #24
Conversation
I'll also note that rendering the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks pretty good, Emily. I am wondering if those files should be pushed as well since the HTML preview here doesn't seem to show any of the figures (though it's possible that's just a quirk of a qmd-rendered HTML file). It would be nice if we could have a fully functional HTML preview
Good point @lshandross - I just pushed the extra files. The HTML preview seems to be working on my end now |
Mine too. It looks really good. Two more minor things though before I think it's ready to merge in:
|
1. remove duplicate "Figure" throughout text 2. add section references 3. update URLs
Good point @lshandross. I fixed the places where "figure" was duplicated, and cleaned up a few additional things. I couldn't find any equations that were not displaying, can you list the sections where I should look? Thanks! |
Noting it seems the problem with preview is no longer an issue. |
Hello @eahowerton and @lshandross , I started to review and make corrections and decided to just go ahead and commit directly to the PR instead of opening another PR. Hope you don't mind (I thought it would be more efficient!) The main things I fixed:
Another cool thing included in the README is a button to launch a binder in the cloud where theoretically anyone can interact with the code. It's not currently working and needs a bit of work. In any case, I've opened an issue (#25 ) to revisit it when I have some time. Combined, this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added some commits and comments in PR
This is the original groundwork to transition from .Rmd to .qmd for the
hubEnsembles
manuscript. This includes the following changes:hubEnsembles_manuscript.qmd
and removinghubEnsembles_manuscript.Rmd
paper.qmd
that was generated byrrtools
. This includes adding preliminary author information (related to add author list explicitly to the vignette #8). Note, this authorship information needs to be reviewed/updated, and I could not get the authors to show up in the .html file.