Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the connection tab #486

Closed
11 tasks done
GriffinRichards opened this issue Oct 28, 2022 · 0 comments · Fixed by #602
Closed
11 tasks done

Improve the connection tab #486

GriffinRichards opened this issue Oct 28, 2022 · 0 comments · Fixed by #602
Labels
bug Something isn't working enhancement New feature or request release target This should be resolved before the next release

Comments

@GriffinRichards
Copy link
Collaborator

GriffinRichards commented Oct 28, 2022

  • There should be a list dropdown for selecting a connection. Currently if a connection is not visible, and not first/last in the list, it cannot be selected. This can happen if connections overlap (and it could also happen if a connection is moved offscreen; this is the only reason moving them offscreen is disallowed)

  • Connecting maps to themselves is not well-supported:

    • If mirroring is on, connecting a map to itself does not show the mirrored connection until the map is reloaded.
    • If mirroring is off, connecting a map to itself does not show the connection on the opposite side (which would appear in-game) (this isn't exactly reflective of in-game behavior, the connection will only appear if loaded via the connected map)
    • If a map has a mirrored connection to itself and the connection's position is changed the mirrored side is not updated until the map is reloaded.
    • Porymap can crash if a map has more than one connection to itself on the same side and one is deleted.
      Connecting maps to themselves is sort of niche, but the crash at least should be fixed.
  • Transparent map border appears above connections after switching maps (51b57f9)

  • Creating a mirrored connection does not mark the connecting map with unsaved changes

  • Connections are not hidden in time when dragging them around
    whoops

  • Connections with unknown direction names will lock their position in the upper right corner. They should log a warning and not be displayed.

  • Calling utility.setBorderVisibility while on the Connections tab can cause the border to render incorrectly (additionally, it never updates the Border checkbox, regardless of which tab is active when it's called)

  • The state of the Mirror to Connecting Maps check box is not saved (should it be? and if so would it be project-specific?)

@GriffinRichards GriffinRichards added bug Something isn't working enhancement New feature or request labels Dec 26, 2022
@GriffinRichards GriffinRichards added the release target This should be resolved before the next release label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request release target This should be resolved before the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant