Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync states for xpu fsdp #2005

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Sync states for xpu fsdp #2005

merged 2 commits into from
Oct 2, 2023

Conversation

abhilash1910
Copy link
Contributor

Adds sync state for fsdp loading on rank 0 -> broadcasted to other xpu ranks.
Links to #1777
cc @pacman100 @muellerzr

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

pacman100
pacman100 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @abhilash1910 for adding this, LGTM!

@pacman100
Copy link
Contributor

cc @muellerzr and @BenjaminBossan

BenjaminBossan
BenjaminBossan approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good, thanks.

muellerzr
muellerzr approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a general comment for future-proofing any more changes

src/accelerate/utils/dataclasses.py Outdated Show resolved Hide resolved
@abhilash1910 @muellerzr
Update src/accelerate/utils/dataclasses.py
5134914 
Co-authored-by: Zach Mueller <muellerzr@gmail.com>
@abhilash1910
Copy link
Contributor Author

abhilash1910 commented Oct 2, 2023 •
edited
Loading

@muellerzr could you re-review and retrigger CI? Thanks.

@muellerzr muellerzr merged commit 420743a into huggingface:main Oct 2, 2023
24 checks passed
@muellerzr
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

@muellerzr muellerzr muellerzr approved these changes

@pacman100 pacman100 pacman100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abhilash1910 @HuggingFaceDocBuilderDev @pacman100 @muellerzr @BenjaminBossan