Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply DVC warning to Accelerate #2197

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Apply DVC warning to Accelerate #2197

merged 5 commits into from
Nov 28, 2023

Conversation

muellerzr
Copy link
Collaborator

What does this PR do?

Same solution as huggingface/transformers#27608, warn when failing trying to log non-scalars as metrics. Makes failing tests pass

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 28, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

src/accelerate/tracking.py Outdated Show resolved Hide resolved
muellerzr and others added 2 commits November 28, 2023 14:53
Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding warning_once !

@muellerzr muellerzr merged commit b04d36c into main Nov 28, 2023
24 checks passed
@muellerzr muellerzr deleted the dvc-warn branch November 28, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants