Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply DVC warning to Accelerate #2197

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Apply DVC warning to Accelerate #2197

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa677bd
Use logger warn instead
muellerzr Nov 28, 2023
d1387c1
Warn
muellerzr Nov 28, 2023
96a16cc
Right import
muellerzr Nov 28, 2023
5959b53
Clean up logs
muellerzr Nov 28, 2023
50220f0
Apply suggestions from code review
muellerzr Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/accelerate/tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,10 +901,19 @@ def log(self, values: dict, step: Optional[int] = None, **kwargs):
kwargs:
Additional key word arguments passed along to `dvclive.Live.log_metric()`.
"""
from dvclive.plots import Metric
if step is not None:
self.live.step = step
for k, v in values.items():
self.live.log_metric(k, v, **kwargs)
if Metric.could_log(v):
self.live.log_metric(k, v, **kwargs)
else:
logger.warning(
"Accelerator attempted to log a value of "
f'"{v}" of type {type(v)} for key "{k} as a scalar. '
muellerzr marked this conversation as resolved.
Show resolved Hide resolved
"This invocation of DVCLive's Live.log_metric() "
"is incorrect so we dropped this attribute."
)

@on_main_process
def finish(self):
Expand Down
Loading