Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: add oneCCL environment variable for non-MPI launcher (accelerate launch) #2339

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Jan 15, 2024

What does this PR do?

@faaany faaany changed the title FIX: add CCL environment variables FIX: add oneCCL environment variables Jan 15, 2024
@faaany
Copy link
Contributor Author

faaany commented Jan 17, 2024

add @ArthurZucker @yao-matrix

@faaany faaany changed the title FIX: add oneCCL environment variables FIX: add oneCCL environment variable for non-MPI launcher (accelerate launch) Jan 17, 2024
@muellerzr
Copy link
Collaborator

@faaany can you do pip install -e .[quality] and do make style; make quality please?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@faaany
Copy link
Contributor Author

faaany commented Jan 18, 2024

@faaany can you do pip install -e .[quality] and do make style; make quality please?

done. Could you pls review it? thanks!

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muellerzr muellerzr merged commit f5c01ee into huggingface:main Jan 18, 2024
23 checks passed
statelesshz pushed a commit to statelesshz/accelerate that referenced this pull request Jan 22, 2024
… launch) (huggingface#2339)

* add ccl env

* add local world size

* set env vars for deepspeed path

* adapt style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants