Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TR] Translated Chapter 1.1 and 1.5 🤗 #105

Merged
merged 6 commits into from
Apr 28, 2022
Merged

[TR] Translated Chapter 1.1 and 1.5 🤗 #105

merged 6 commits into from
Apr 28, 2022

Conversation

mertbozkir
Copy link
Contributor

I think the translations are done, sorry for the late pr about chapter 1.1

Also I saw that nobody take responsibility about 1.5, I finished it, too 💥#41

I think there are some configurations for rendering in the website, YAML config, etc. But I don't know how to do it. So it needs review @lewtun 😣

@mertbozkir mertbozkir changed the title Translated Chapter 1.1 and 1.5 🤗 [TR] Translated Chapter 1.1 and 1.5 🤗 Apr 8, 2022
Copy link
Contributor

@akkasayaz akkasayaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read it through and made some suggestions from a reader's perspective. I think that other parts are excellent


**Lewis Tunstall** Hugging Face'de Makine Öğrenmesi Mühendisi, açık kaynak araçları geliştirmeye ve bunlari daha geniş bir topluluk için ulaşılabilir hale getirmeye odaklanmış. Ayrıca yakında gelecek olan [Transformers üzerine O’Reilly kitabının](https://www.oreilly.com/library/view/natural-language-processing/9781098103231/) yazarlarından biri.

**Leandro von Werra** Hugging Face'de Açık-Kaynak takımında Makine Öğrenmesi Mühendisi ve ayrica yakında gelecek olan [Transformers üzerine olan O’Reilly kitabinin](https://www.oreilly.com/library/view/natural-language-processing/9781098103231/) yazarlarından biri. Tüm Makine Öğrenmesi stack'inde çalişarak NLP projelerini üretime getiren birkaç yıllık endüstri deneyimine sahiptir.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is a bit hard to understand "Tüm Makine Öğrenmesi stack'inde çalişarak"

Copy link
Contributor Author

@mertbozkir mertbozkir Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I don't know how to explain "by working across the whole machine learning stack", any suggestion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I can explain it well but I assume that it means working on every single step of it. Maybe I am wrong here but you are right it is also a bit hard to understand the English version too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies that the English isn't super clear here. What we mean here is to work on all aspects of machine learning, i.e. from training models to deploying them. Does that help?

chapters/tr/chapter1/5.mdx Outdated Show resolved Hide resolved
mertbozkir and others added 2 commits April 8, 2022 16:10
Co-authored-by: Ayaz Akkaş <59310292+akkasayaz@users.noreply.github.com>
Co-authored-by: Ayaz Akkaş <59310292+akkasayaz@users.noreply.github.com>
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this awesome contribution @mertbozkir 🥳 ! I think the only thing missing is the sections in the _toctree.yml file, e.g. can you please add:

- title: 1. Transformer modelleri
  sections:
  - local: chapter1/1
    title: Introduction # Translate this
  - local: chapter1/2
    title: Doğal Dil İşleme
  - local: chapter1/5
    title: Encoder models # <= Translate this

@lewtun
Copy link
Member

lewtun commented Apr 20, 2022

Hey @mertbozkir just checking if you'd like any help from myself or @akkasayaz on adding the _toctree.yml file to this PR? I think with that this PR will be ready to go 🚀 !

@akkasayaz
Copy link
Contributor

akkasayaz commented Apr 27, 2022

if you'd like any help from myself or @akkasayaz

lol if I knew how to do I would help but UF I don't.

@mertbozkir
Copy link
Contributor Author

mertbozkir commented Apr 28, 2022

@lewtun I don't know how to do it 🥲
Can you show us the first time? :D

I'm a little busy, I will look at this PR on weekends. 🤗

@lewtun
Copy link
Member

lewtun commented Apr 28, 2022

@lewtun I don't know how to do it 🥲
Can you show us the first time? :D

Sure! I just pushed the changes to the table of contents in 99a8bb8 , but there's two lines there that need translating to Turkish. After that, I think this will be good to go!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 28, 2022

The documentation is not available anymore as the PR was closed or merged.

chapters/tr/_toctree.yml Outdated Show resolved Hide resolved
chapters/tr/_toctree.yml Outdated Show resolved Hide resolved
@lewtun
Copy link
Member

lewtun commented Apr 28, 2022

Thanks, this looks great!

@lewtun lewtun merged commit 5460a70 into huggingface:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants