-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor patching to specific submodule (#2639)
* Create patching submodule * Minor fix in docstring section header
- Loading branch information
1 parent
4aff493
commit c722810
Showing
2 changed files
with
68 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
from .logging import get_logger | ||
|
||
|
||
logger = get_logger(__name__) | ||
|
||
|
||
class _PatchedModuleObj: | ||
"""Set all the modules components as attributes of the _PatchedModuleObj object.""" | ||
|
||
def __init__(self, module): | ||
if module is not None: | ||
for key in getattr(module, "__all__", module.__dict__): | ||
if not key.startswith("__"): | ||
setattr(self, key, getattr(module, key)) | ||
|
||
|
||
class patch_submodule: | ||
""" | ||
Patch a submodule attribute of an object, by keeping all other submodules intact at all levels. | ||
Examples: | ||
>>> import importlib | ||
>>> from datasets.load import prepare_module | ||
>>> from datasets.streaming import patch_submodule, xjoin | ||
>>> | ||
>>> snli_module_path, _ = prepare_module("snli") | ||
>>> snli_module = importlib.import_module(snli_module_path) | ||
>>> patcher = patch_submodule(snli_module, "os.path.join", xjoin) | ||
>>> patcher.start() | ||
>>> assert snli_module.os.path.join is xjoin | ||
""" | ||
|
||
_active_patches = [] | ||
|
||
def __init__(self, obj, target: str, new): | ||
self.obj = obj | ||
self.target = target | ||
self.new = new | ||
self.key = target.split(".")[0] | ||
self.original = getattr(obj, self.key, None) | ||
|
||
def __enter__(self): | ||
*submodules, attr = self.target.split(".") | ||
current = self.obj | ||
for key in submodules: | ||
setattr(current, key, _PatchedModuleObj(getattr(current, key, None))) | ||
current = getattr(current, key) | ||
setattr(current, attr, self.new) | ||
|
||
def __exit__(self, *exc_info): | ||
setattr(self.obj, self.key, self.original) | ||
|
||
def start(self): | ||
"""Activate a patch.""" | ||
self.__enter__() | ||
self._active_patches.append(self) | ||
|
||
def stop(self): | ||
"""Stop an active patch.""" | ||
try: | ||
self._active_patches.remove(self) | ||
except ValueError: | ||
# If the patch hasn't been started this will fail | ||
return None | ||
|
||
return self.__exit__() |
c722810
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show benchmarks
PyArrow==3.0.0
Show updated benchmarks!
Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
Show updated benchmarks!
Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json