Re-apply input columns change #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
albertvillanova
approved these changes
Sep 22, 2022
Comment on lines
-2803
to
-2804
| if remove_columns: | ||
| remove_columns = list(set(remove_columns) & set(input_columns)) |
There was a problem hiding this comment.
I guess this was the source of the issue with filter...
I'm wondering why this was introduced in:
There was a problem hiding this comment.
I guess the contributor misinterpreted the purpose of input_columns and remove_columns in that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
filter+input_columnscombination, which is used in thetransformersexamples for instance.Revert #5006 (which in turn reverts #4971)
Fix #4858