Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify imagefolder is for small datasets #5329

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

stevhliu
Copy link
Member

@stevhliu stevhliu commented Dec 1, 2022

Based on feedback from here, this PR adds a note to the imagefolder loading and creating docs that imagefolder is designed for small scale image datasets.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 1, 2022

The documentation is not available anymore as the PR was closed or merged.

@polinaeterna
Copy link
Contributor

I think it's also reasonable to add the same note to the AudioFolder decription

@lhoestq
Copy link
Member

lhoestq commented Dec 2, 2022

Thank you ! I think "regular" is more appropriate than "small". It can easily scale to a few thousands of images - just not millions x)

@stevhliu
Copy link
Member Author

stevhliu commented Dec 2, 2022

Replaced "small" with "several thousand" since what is considered "regular" and even "small" can be kind of vague!

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@stevhliu stevhliu merged commit cb8dd98 into huggingface:main Dec 6, 2022
@stevhliu stevhliu deleted the imagefolder-feedback branch December 6, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants