Fix parseShardedIndex validation error, cap maximum sharded json file #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coyotte508
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Slightly more efficient alternative is to rely on the content-length header of the response
Since the fetch is in two stages:
- get the headers
- download the content
So if we check the content-length between the two stages, we don't have to download any data (and don't need to rely on the range)
julien-c
reviewed
Feb 23, 2024
| }); | ||
|
|
||
| if (!indexResp) { | ||
| throw new SafetensorParseError(`Failed to parse file ${path}: failed to fetch safetensors index.`); | ||
| } | ||
|
|
||
| // no validation for now, we assume it's a valid IndexJson. | ||
| const index: SafetensorsIndexJson = await indexResp.json(); | ||
| let index: SafetensorsIndexJson; |
There was a problem hiding this comment.
remove the comment one line above then?
There was a problem hiding this comment.
It's still true we don't enforce any validation on the payload except being a JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.