Define all errors in ./src/huggingface_hub/errors.py

[Wauplin]

Custom exceptions are defined in various places across the codebase. For consistency, we should define them all in ./src/huggingface_hub/errors.py.

Requested by @albertvillanova in huggingface/datasets#6296.

[Y4suyuki]

Hi, I'm interested in taking on this issue. It seems like a great starting point for me.

[Wauplin]

Hi @Y4suyuki, thanks for proposing your help on this issue! Do you need any additional information before giving it a try or is it clear? Happy to review a PR or answer any questions. I do think it'd be best to start a PR only with a few errors and then extend it once we've agreed on how to proceed. Thanks in advance!

[Y4suyuki]

Hi @Wauplin , I've created a PR that moves several custom errors into errors.py.

I have one question:
Do functions closely related to errors, like _parse_text_generation_error , also need to be moved to errors.py or errors.py simply cotntains custom errors only?

I thought errors.py should simply contains custom errors and implemented so in PR but I'm asking just in case.

[Wauplin]

Do functions closely related to errors, like _parse_text_generation_error , also need to be moved to errors.py or errors.py simply cotntains custom errors only?
I thought errors.py should simply contains custom errors and implemented so in PR but I'm asking just in case.

Yes, you're absolutely right! We only want errors to be defined in errors.py. Any other logic might be hard to maintain if it causes circular imports for example. So let's keep errors.py minimal as you did in the PR. Thanks for your contribution and kicking off this topic!! 🔥