Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define errors in errors file #2202

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

lappemic
Copy link
Contributor

@lappemic lappemic commented Apr 8, 2024

Following the suggestion in issue #2069, I've moved TemplateError from huggingface_hub/inference/_templating.py to huggingface_hub/errors.py. I've also organized the errors alphabetically to simplify navigation and future maintenance. I hope this small contribution helps.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such things as small contributions 😉 Thanks for your contribution @lappemic! :)

@Wauplin Wauplin merged commit bbb00ac into huggingface:main Apr 8, 2024
10 of 14 checks passed
@lappemic lappemic deleted the define_errors_in_errors_file branch April 8, 2024 12:26
@lappemic
Copy link
Contributor Author

lappemic commented Apr 8, 2024

Thank you very much @Wauplin! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants