-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define errors in errors.py #2170
Define errors in errors.py #2170
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@Wauplin Hi, I made another PR for defining errors. |
Thanks for the contribution and explanations @Y4suyuki! Your reasoning looks good. I'll have a look at your PR next week and let you know :) In the meantime, have a great weekend 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Y4suyuki! I played with it a bit and it's definitely much cleaner now! 🎉
And thanks for taking care of not introducing breaking changes. I agree it makes imports redundant but for libraries like this one it's more important not to brake downstream usage rather than having a perfectly clean library internally.
Define errors in utils except
utils/_errors.py
in errors.py#2069