-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spaCy to inference API #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions, not a full review yet.
api-inference-community/docker_images/spacy/app/pipelines/token_classification.py
Outdated
Show resolved
Hide resolved
api-inference-community/docker_images/spacy/app/pipelines/token_classification.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test in tests/test_dockers.py
too so we can check the behaviors ?
Done :) thanks for the suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Allow using spaCy for token classification (only NER at the moment). This is only allowed-list for spaCy org models.