Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spaCy to inference API #63

Merged
merged 6 commits into from
Jun 4, 2021
Merged

Add spaCy to inference API #63

merged 6 commits into from
Jun 4, 2021

Conversation

osanseviero
Copy link
Member

@osanseviero osanseviero commented Jun 1, 2021 •
edited
Loading

Allow using spaCy for token classification (only NER at the moment). This is only allowed-list for spaCy org models.

@osanseviero osanseviero marked this pull request as ready for review June 1, 2021 12:43
@osanseviero osanseviero requested a review from Narsil June 1, 2021 12:43
Narsil
Narsil reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, not a full review yet.

api-inference-community/docker_images/spacy/app/pipelines/token_classification.py Outdated Show resolved Hide resolved
api-inference-community/docker_images/spacy/app/pipelines/token_classification.py Outdated Show resolved Hide resolved
api-inference-community/docker_images/spacy/Dockerfile Show resolved Hide resolved
@osanseviero osanseviero requested a review from Narsil June 1, 2021 13:31
Narsil
Narsil reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test in tests/test_dockers.py too so we can check the behaviors ?

api-inference-community/docker_images/spacy/requirements.txt Outdated Show resolved Hide resolved
@osanseviero
Copy link
Member Author

Done :) thanks for the suggestion

@osanseviero osanseviero requested a review from Narsil June 3, 2021 17:20
Narsil
Narsil approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osanseviero osanseviero merged commit 5585292 into main Jun 4, 2021
@osanseviero osanseviero deleted the spacy_inference branch June 4, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narsil Narsil Narsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@osanseviero @Narsil