Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading generation config if it is part of model #750

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Jun 6, 2024

What does this PR do?

there is misalignment with behaviour how we convert model and how to load in generation config part. In some cases, generation config parameters can be different from default and not provided in config. I see issue with attempt to run whisper-tiny with pipelines due to difference in generation config, when openvino model loaded and when original pytorch model (due to obtaining generation config from model config instead of using provided with model before conversion)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eaidova eaidova marked this pull request as ready for review June 6, 2024 10:03
@eaidova
Copy link
Collaborator Author

eaidova commented Jun 6, 2024

@echarlaix could you please take a look?

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for the fix @eaidova

Co-authored-by: Ella Charlaix <80481427+echarlaix@users.noreply.github.com>
@echarlaix echarlaix merged commit d5dbb3d into huggingface:main Jun 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants