Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend AdaptionPrompt and Add Multi-Modal AdaptionPromptV2 #763

Closed
wants to merge 34 commits into from

Conversation

PanQiWei
Copy link
Contributor

What does this PR to

This PR:

@pacman100 @younesbelkada if this pr look good to you guys, I will close #398 and keep working on this one to make it merge-able 🙏

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@BenjaminBossan
Copy link
Member

Hi, thanks for you continued work. Could you please run make style so that the code quality checks passes and the rest of the CI can run?

@PanQiWei
Copy link
Contributor Author

PanQiWei commented Aug 4, 2023

The tests are passed, I will futher improve documentation and add some more tests, then I think this pr can be reviewd ❤️‍🔥

@BenjaminBossan
Copy link
Member

I'm wondering: Would it be a lot of work for you to split the two changes you suggested into separate PRs? That would make it easier for us to review the changes.

@PanQiWei
Copy link
Contributor Author

PanQiWei commented Aug 4, 2023

Not at all, I will do it this weekend after my jobs done on auto-gptq

@BenjaminBossan
Copy link
Member

That would be fantastic, big thanks.

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @PanQiWei for the impressive work on extending AdaptionPrompt to more models and adding the Multi-Modal AdaptionPromptV2 🔥🚀✨.

It would be great if we can have a Multi-Modal AdaptionPromptV2 example script or notebook in examples folder so that users can leverage it out of the box. Apart from that good to merge.

src/peft/tuners/adaption_prompt.py Outdated Show resolved Hide resolved
Co-authored-by: Sourab Mangrulkar <13534540+pacman100@users.noreply.github.com>
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

@github-actions github-actions bot closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants