Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing make target platform for local install: 'install-flash-attention-v2' #1414

Merged

Conversation

deepily
Copy link
Contributor

@deepily deepily commented Jan 8, 2024

What does this PR do?

Create a platform appropriate make target string issued by flash_attn.py when it catches an import error.

Fixes #1397

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@deepily deepily changed the title Fix missing make target platform for local install: 'install-flash-attention-v2' (#1397) Fix missing make target platform for local install: 'install-flash-attention-v2' Jan 8, 2024
Copy link
Member

@OlivierDehaene OlivierDehaene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@OlivierDehaene OlivierDehaene merged commit 91d7267 into huggingface:main Jan 9, 2024
@deepily deepily deleted the bugfix-1397-missing-make-target branch January 9, 2024 19:12
kdamaszk pushed a commit to kdamaszk/tgi-gaudi that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Install: No rule to make target 'install-flash-attention-v2'
2 participants