Skip to content

Commit

Permalink
Further refactor
Browse files Browse the repository at this point in the history
  • Loading branch information
helloworld1 committed Apr 5, 2024
1 parent a616ce9 commit 1fb2ed2
Showing 1 changed file with 6 additions and 20 deletions.
26 changes: 6 additions & 20 deletions src/transformers/integrations/integration_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,25 +131,6 @@ def is_mlflow_available():
return importlib.util.find_spec("mlflow") is not None


def is_mlflow_async_log_available():
# MLFlow can also be provided from mlflow-skinny package, which has the same versioning of mlflow package.
for mlflow_package_name in ["mlflow", "mlflow-skinny"]:
try:
mlflow_version = importlib.metadata.version(mlflow_package_name)

# "synchronous" flag is only available with mlflow version >= 2.8.0
# https://github.com/mlflow/mlflow/pull/9705
# https://github.com/mlflow/mlflow/releases/tag/v2.8.0
if packaging.version.parse(mlflow_version) >= packaging.version.parse("2.8.0"):
return True
except importlib.metadata.PackageNotFoundError:
# We will try different mlflow package candidates
pass

# If MLFlow version cannot be determined, fallback to not doing async log to be safe
return False


def is_dagshub_available():
return None not in [importlib.util.find_spec("dagshub"), importlib.util.find_spec("mlflow")]

Expand Down Expand Up @@ -1017,7 +998,12 @@ def setup(self, args, state, model):
self._experiment_name = os.getenv("MLFLOW_EXPERIMENT_NAME", None)
self._flatten_params = os.getenv("MLFLOW_FLATTEN_PARAMS", "FALSE").upper() in ENV_VARS_TRUE_VALUES
self._run_id = os.getenv("MLFLOW_RUN_ID", None)
self._async_log = is_mlflow_async_log_available()

# "synchronous" flag is only available with mlflow version >= 2.8.0
# https://github.com/mlflow/mlflow/pull/9705
# https://github.com/mlflow/mlflow/releases/tag/v2.8.0
self._async_log = packaging.version.parse(self._ml_flow.__version__) >= packaging.version.parse("2.8.0")

logger.debug(
f"MLflow experiment_name={self._experiment_name}, run_name={args.run_name}, nested={self._nested_run},"
f" tags={self._nested_run}, tracking_uri={self._tracking_uri}"
Expand Down

0 comments on commit 1fb2ed2

Please sign in to comment.