Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of warnings.warn #26381

Closed
osanseviero opened this issue Sep 25, 2023 · 9 comments · Fixed by #26527
Closed

Remove usage of warnings.warn #26381

osanseviero opened this issue Sep 25, 2023 · 9 comments · Fixed by #26527

Comments

@osanseviero
Copy link
Member

osanseviero commented Sep 25, 2023

Usage of warnings.warn has been deprecated in favor of logging.warning, which is managed by the transformers.logging utility.

warnings.warn may still be leveraged for situations where a single warning per runtime is favored, but this will be deprecated in the future as well.

@sahilbhosale63
Copy link
Contributor

Hi @osanseviero I want to work on this issue. Can you please this issue to me so that I can start working on it?

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 25, 2023

If I understand correctly, we should use logger.warning where logger = logging.get_logger(__name__) ?

@hegdeadithyak
Copy link
Contributor

I can work on this!!

@sachinSingh16-09
Copy link
Contributor

hey @osanseviero, I have started solving the issue. Please assign this issue to me.

@riiyaa24
Copy link
Contributor

Hello, Can I work on this issue? Can you please assign me this?

@LysandreJik
Copy link
Member

Hello, we have worked on a different approach with Omar that will not require us to change all warnings to logging statements.

I'm opening a PR here implementing it: #26527

However, in order to honor the contributions you have wanted to make (or have already started making!), I have put you all five as co-authors of the commit, @sahilbhosale63, @Adithya4720, @sachinSingh16-09, @riiyaa24.

I have added the HACKTOBERFEST-ACCEPTED tag in case you're participating.

Thanks once again for your contribution, and we're looking forward to the next one 🤗

@hegdeadithyak
Copy link
Contributor

Thanks!!

@AVAniketh0905
Copy link
Contributor

Is this still open?

@LysandreJik
Copy link
Member

It will be closed by #26527 @AVAniketh0905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants