Warnings controlled by logger level #26527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ArthurZucker
approved these changes
Oct 2, 2023
| @@ -71,6 +71,19 @@ verbose to the most verbose), those levels (with their corresponding int values | |||
|
|
|||
| By default, `tqdm` progress bars will be displayed during model download. [`logging.disable_progress_bar`] and [`logging.enable_progress_bar`] can be used to suppress or unsuppress this behavior. | |||
|
|
|||
| ## `logging` vs `warnings` | |||
There was a problem hiding this comment.
Can you add an example of what this means for us now?
(calling logger with deprecation warning for example?) for all devs !
There was a problem hiding this comment.
You don't call logger with deprecation warnings, you just use warnings.warn. But now, you can capture those and eliminate them from the logging system simply.
Co-authored-by: Sahil Bhosale <sahilbhosale63@live.com> Co-authored-by: Adithya4720 <hegdeadithyak@gmail.com> Co-authored-by: Sachin Singh <sachinishu02@gmail.com> Co-authored-by: Riya Dhanduke <113622644+riiyaa24@users.noreply.github.com>
LysandreJik
force-pushed
the
logger-level
branch
from
5880e05
to
6a60643
Compare
helboukkouri
pushed a commit
to helboukkouri/transformers
that referenced
this pull request
Oct 16, 2023
* Logger level Co-authored-by: Sahil Bhosale <sahilbhosale63@live.com> Co-authored-by: Adithya4720 <hegdeadithyak@gmail.com> Co-authored-by: Sachin Singh <sachinishu02@gmail.com> Co-authored-by: Riya Dhanduke <113622644+riiyaa24@users.noreply.github.com> * More comprehensive documentation --------- Co-authored-by: Sahil Bhosale <sahilbhosale63@live.com> Co-authored-by: Adithya4720 <hegdeadithyak@gmail.com> Co-authored-by: Sachin Singh <sachinishu02@gmail.com> Co-authored-by: Riya Dhanduke <113622644+riiyaa24@users.noreply.github.com>
blbadger
pushed a commit
to blbadger/transformers
that referenced
this pull request
Nov 8, 2023
* Logger level Co-authored-by: Sahil Bhosale <sahilbhosale63@live.com> Co-authored-by: Adithya4720 <hegdeadithyak@gmail.com> Co-authored-by: Sachin Singh <sachinishu02@gmail.com> Co-authored-by: Riya Dhanduke <113622644+riiyaa24@users.noreply.github.com> * More comprehensive documentation --------- Co-authored-by: Sahil Bhosale <sahilbhosale63@live.com> Co-authored-by: Adithya4720 <hegdeadithyak@gmail.com> Co-authored-by: Sachin Singh <sachinishu02@gmail.com> Co-authored-by: Riya Dhanduke <113622644+riiyaa24@users.noreply.github.com>
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 18, 2023
* Logger level Co-authored-by: Sahil Bhosale <sahilbhosale63@live.com> Co-authored-by: Adithya4720 <hegdeadithyak@gmail.com> Co-authored-by: Sachin Singh <sachinishu02@gmail.com> Co-authored-by: Riya Dhanduke <113622644+riiyaa24@users.noreply.github.com> * More comprehensive documentation --------- Co-authored-by: Sahil Bhosale <sahilbhosale63@live.com> Co-authored-by: Adithya4720 <hegdeadithyak@gmail.com> Co-authored-by: Sachin Singh <sachinishu02@gmail.com> Co-authored-by: Riya Dhanduke <113622644+riiyaa24@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explicitely shows how to control
warningsusing thelogginglevel setters in `transformers.Fix #26381