Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silenced error while downloading pretrained model #5869

Closed
festeh opened this issue Jul 18, 2020 · 2 comments 路 Fixed by #8324
Closed

Silenced error while downloading pretrained model #5869

festeh opened this issue Jul 18, 2020 · 2 comments 路 Fixed by #8324
Labels
wontfix

Comments

@festeh
Copy link

festeh commented Jul 18, 2020 •
edited

馃悰 Bug

Currently, if user failed to download a model, they will receive uninformative and confusing message (see #5787). This is most hurting for users behind a proxy. This happens because of this line. My opinion is that there should be at least a warning, and if force_download is True, then error should be raised. I can make a PR if you agree with that.
@julien-c
Copy link
Member

This sounds reasonable

@festeh festeh mentioned this issue Jul 20, 2020
Closed
@stale
Copy link

stale bot commented Sep 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 19, 2020
@stale stale bot closed this as completed Sep 26, 2020
@julien-c julien-c linked a pull request Nov 5, 2020 that will close this issue
Model versioning #8324
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
2 participants
@julien-c @festeh